From e592a0805a94ee683cad94dafcfba874928c8888 Mon Sep 17 00:00:00 2001
From: kevinpauer <kevinpauer@t-online.de>
Date: Wed, 6 Apr 2022 17:04:38 +0200
Subject: [PATCH] Fix placeholder bug and improve code quality

---
 frontend/src/app/Helpers/helper.service.ts                  | 3 ++-
 .../src/app/Views/bot-settings/bot-settings.component.html  | 2 +-
 .../src/app/Views/bot-settings/bot-settings.component.ts    | 6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/frontend/src/app/Helpers/helper.service.ts b/frontend/src/app/Helpers/helper.service.ts
index 24d485e..60a57c6 100644
--- a/frontend/src/app/Helpers/helper.service.ts
+++ b/frontend/src/app/Helpers/helper.service.ts
@@ -28,7 +28,8 @@ export class HelperService {
     return shares;
   }
 
-  formatKeywordsData(keywords: Keyword[]) {
+  formatKeywordsData(): Keyword[] {
+    var keywords: Keyword[] = [];
     this.botService.getKeywords().subscribe((result) => {
       var data = JSON.parse(result);
       for (let i = 0; i < data.data.length; i++) {
diff --git a/frontend/src/app/Views/bot-settings/bot-settings.component.html b/frontend/src/app/Views/bot-settings/bot-settings.component.html
index cee4a8a..8318bb9 100644
--- a/frontend/src/app/Views/bot-settings/bot-settings.component.html
+++ b/frontend/src/app/Views/bot-settings/bot-settings.component.html
@@ -44,7 +44,7 @@
               </button>
             </mat-chip>
             <input
-              placeholder="New fruit..."
+              placeholder="New share..."
               [matChipInputFor]="sharesList"
               [matChipInputSeparatorKeyCodes]="separatorKeysCodes"
               [matChipInputAddOnBlur]="addOnBlur"
diff --git a/frontend/src/app/Views/bot-settings/bot-settings.component.ts b/frontend/src/app/Views/bot-settings/bot-settings.component.ts
index 1e0c8a7..6974b24 100644
--- a/frontend/src/app/Views/bot-settings/bot-settings.component.ts
+++ b/frontend/src/app/Views/bot-settings/bot-settings.component.ts
@@ -29,7 +29,7 @@ export class BotSettingsComponent implements OnInit {
 
   ngOnInit(): void {
     this.shares = this.helper.formatShareData();
-    this.helper.formatKeywordsData(this.keywords);
+    this.keywords = this.helper.formatKeywordsData();
   }
 
   addOnBlur = true;
@@ -52,7 +52,7 @@ export class BotSettingsComponent implements OnInit {
     if (value) {
       await this.helper.delay(1000);
       this.keywords = [];
-      this.keywords = this.helper.formatKeywordsData(this.keywords);
+      this.keywords = this.helper.formatKeywordsData();
     }
   }
 
@@ -64,7 +64,7 @@ export class BotSettingsComponent implements OnInit {
     await this.helper.delay(1000);
 
     this.keywords = [];
-    this.keywords = this.helper.formatKeywordsData(this.keywords);
+    this.keywords = this.helper.formatKeywordsData();
   }
 
   async addShare(event: MatChipInputEvent): Promise<void> {